Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removes pjson and directly requires package.json #504

Merged
merged 1 commit into from
Mar 14, 2018
Merged

removes pjson and directly requires package.json #504

merged 1 commit into from
Mar 14, 2018

Conversation

aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Mar 14, 2018

Summary

fixes #478

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Mar 14, 2018 •
edited

Codecov Report

Merging #504 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #504   +/-   ##
=======================================
  Coverage   81.32%   81.32%           
=======================================
  Files           6        6           
  Lines         241      241           
  Branches       37       37           
=======================================
  Hits          196      196           
  Misses         29       29           
  Partials       16       16
Impacted Files Coverage Δ
src/WebClient.ts 80.91% <100%> (ø) ⬆️
src/util.ts 67.56% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee4b03...8e4da08. Read the comment docs.

@aoberoi
Copy link
Contributor Author

aoberoi commented Mar 14, 2018

tested locally in a project without a "name" or "version" defined in the package.json with this script:

const { WebClient } = require('@slack/client');

const web = new WebClient('xoxb-REDACTED');

console.log(web.userAgent);

web.channels.list()
  .then(console.log)
  .catch(console.error);

output:

@slack:client/4.0.0 node/8.10.0 darwin/17.4.0
{ ok: true,
  channels: 
   [ /* SNIP */ ],
  acceptedScopes: [ 'channels:read', 'read' ] }

@aoberoi aoberoi merged commit 945439a into slackapi:master Mar 14, 2018
@aoberoi aoberoi deleted the remove-pjson branch March 14, 2018 21:00
@wilhelmklopp
Copy link

🤘 Thanks!

@dependabot-preview dependabot-preview bot mentioned this pull request Mar 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roach Roach Roach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pjson reads incorrect package.json?
3 participants
@aoberoi @wilhelmklopp @Roach